Mousius commented on a change in pull request #8914:
URL: https://github.com/apache/tvm/pull/8914#discussion_r703335133
##########
File path: include/tvm/ir/module.h
##########
@@ -122,6 +122,7 @@ class IRModuleNode : public Object {
v->Visit("global_var_map_", &global_var_map_);
v->Visit("global_type_var_map_", &global_type_var_map_);
v->Visit("source_map", &source_map);
+ v->Visit("attrs", &attrs);
Review comment:
Hi @manupa-arm, `attrs` were actually added to `IRModule` in
https://github.com/apache/tvm/pull/8750 so anything we do now is an iterative
improvement on that. Given this series of PRs aims to remove the `Map<Target,
IRModule>` entirely (this one removes the `per_target_module` from the
interpreter) I don't think we need to ensure the copy happens here but I agree
we should have some test coverage when the unified `IRModule` is lowered to
ensure it contains all the attributes we've accrued - this should be a follow
up when we change the interface from `Map<Target, IRModule>` to `IRModule` -
does that sound reasonable to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
