manupa-arm commented on a change in pull request #8914:
URL: https://github.com/apache/tvm/pull/8914#discussion_r703364877
##########
File path: include/tvm/ir/module.h
##########
@@ -122,6 +122,7 @@ class IRModuleNode : public Object {
v->Visit("global_var_map_", &global_var_map_);
v->Visit("global_type_var_map_", &global_type_var_map_);
v->Visit("source_map", &source_map);
+ v->Visit("attrs", &attrs);
Review comment:
Its not very clear to me how we can avoid per_target_module throughout
the lowering process -- we could push it way down.
Unified IRModule --> per_target_modules (lowered_funcs) --> runtime.Modules
Unless Im missing something here, there will always be a stage that IRModule
contains things that gets lowered to a single runtime.Module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
