mbs-octoml commented on a change in pull request #8914:
URL: https://github.com/apache/tvm/pull/8914#discussion_r706195612
##########
File path: include/tvm/ir/module.h
##########
@@ -122,6 +122,7 @@ class IRModuleNode : public Object {
v->Visit("global_var_map_", &global_var_map_);
v->Visit("global_type_var_map_", &global_type_var_map_);
v->Visit("source_map", &source_map);
+ v->Visit("attrs", &attrs);
Review comment:
+1 to:
- preserving module attrs through all passes on the assumption they apply
to all targets
- xfering them when we project a cross-target IRModule to a specific-target
IRModule just before the transition into lowering phases
We should probably have a convention that IRModule attrs should be for
describing properties of the code and not of the compilation? Since they will
appear everywhere it would be tempting to start adding Target-like things there.
Does anyone have thoughts on whether we should try to line up the IRModule
and runtime::Module worlds?
```
cross-target single-target
IR IRModule ?
Executable ? runtime::Module
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
