electriclilies commented on a change in pull request #8914:
URL: https://github.com/apache/tvm/pull/8914#discussion_r706356687
##########
File path: include/tvm/ir/module.h
##########
@@ -122,6 +122,7 @@ class IRModuleNode : public Object {
v->Visit("global_var_map_", &global_var_map_);
v->Visit("global_type_var_map_", &global_type_var_map_);
v->Visit("source_map", &source_map);
+ v->Visit("attrs", &attrs);
Review comment:
That convention sounds good to me, but one thing we should be cautious
of is that the attributes of functions do contain properties of the compilation
flow (like targets), and this is inconsistent.
@mbs-octoml By lining up the IRModule and runtime::Module worlds do you mean
also moving to a world where runtime::Modules are cross-target? I'm honestly
not sure if that's something we want to do. @areusch do you have any thoughts
about this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
