manupa-arm commented on a change in pull request #8914:
URL: https://github.com/apache/tvm/pull/8914#discussion_r703762775
##########
File path: include/tvm/ir/module.h
##########
@@ -122,6 +122,7 @@ class IRModuleNode : public Object {
v->Visit("global_var_map_", &global_var_map_);
v->Visit("global_type_var_map_", &global_type_var_map_);
v->Visit("source_map", &source_map);
+ v->Visit("attrs", &attrs);
Review comment:
So the attrs of IRModule are globally valid to all targets. There I feel
conveying them to the codegen might still be beneficial.
For 1, we would need to expand the build API to pass the attrs
For 2, we can embed them to each IRModule.
The attrs allows a channel that pass through all of the unified lowering
process up until the concept of IRModule cease to exist.
If you agree, I feel we should pass them in to the per target IRModule, then
later changed in either way we decide to proceed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
