electriclilies commented on a change in pull request #8914:
URL: https://github.com/apache/tvm/pull/8914#discussion_r703755898
##########
File path: include/tvm/ir/module.h
##########
@@ -122,6 +122,7 @@ class IRModuleNode : public Object {
v->Visit("global_var_map_", &global_var_map_);
v->Visit("global_type_var_map_", &global_type_var_map_);
v->Visit("source_map", &source_map);
+ v->Visit("attrs", &attrs);
Review comment:
Most likely, although I have not dug into that part of the codebase in
depth yet so I can't say for sure.
The two options that I think are most likely are
1. `build` consuming the IRModule directly, traversing the functions in the
IRModule and dealing with each directly (which is what you just mentioned)
2. Right before `build` is invoked, separating the functions in the module
by Target (although we wouldn't store them in a `Map<Target, IRModule>`)
So to summarize, we'll either completely remove the data structure that
stores functions separated by target, or just push it all the way down to right
before `build` is called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
