csullivan commented on a change in pull request #10493:
URL: https://github.com/apache/tvm/pull/10493#discussion_r821218945
##########
File path: cmake/modules/Hexagon.cmake
##########
@@ -238,7 +246,8 @@ if(USE_HEXAGON_RPC)
list(APPEND RUNTIME_HEXAGON_SRCS
"${TVMRT_SOURCE_DIR}/hexagon/rpc/hexagon_rpc_stub.c"
)
- target_link_libraries(tvm_runtime PRIVATE cdsprpc)
+ target_link_libraries(tvm PRIVATE dl log ${CDSPRPC_LIBRARY})
Review comment:
Was there a reason for adding in linking libtvm.so here? In some of the
builds we only build libtvm_runtime.so, e.g. for Android and also for Hexagon
device code, so libtvm.so can't be linked, but we still want custom runtime
logging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
