kparzysz-quic commented on a change in pull request #10493:
URL: https://github.com/apache/tvm/pull/10493#discussion_r821981710
##########
File path: cmake/modules/Hexagon.cmake
##########
@@ -238,7 +246,8 @@ if(USE_HEXAGON_RPC)
list(APPEND RUNTIME_HEXAGON_SRCS
"${TVMRT_SOURCE_DIR}/hexagon/rpc/hexagon_rpc_stub.c"
)
- target_link_libraries(tvm_runtime PRIVATE cdsprpc)
+ target_link_libraries(tvm PRIVATE dl log ${CDSPRPC_LIBRARY})
Review comment:
I don't understand how this answers the question... Why did you add
"target_link_libraries" for "tvm" here? `libtvm.so` will never be built for
Android. Is it just for completeness in case it's added at some point in the
future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
