tkonolige commented on a change in pull request #10493:
URL: https://github.com/apache/tvm/pull/10493#discussion_r821227200
##########
File path: cmake/modules/Hexagon.cmake
##########
@@ -238,7 +246,8 @@ if(USE_HEXAGON_RPC)
list(APPEND RUNTIME_HEXAGON_SRCS
"${TVMRT_SOURCE_DIR}/hexagon/rpc/hexagon_rpc_stub.c"
)
- target_link_libraries(tvm_runtime PRIVATE cdsprpc)
+ target_link_libraries(tvm PRIVATE dl log ${CDSPRPC_LIBRARY})
Review comment:
The reason was so that I could add linked libraries after the targets
were created. And I needed the targets to be created before this so that I
could properly add definitions (in this case `USE_HEXAGON_LOGGING=1`) so that
they would exist only for the target and would not pollute the global namespace.
If the tvm target is not created, then I'll have to think of a different
approach. Note that creating the target doesn't mean you have to build it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
