kparzysz-quic commented on pull request #10493: URL: https://github.com/apache/tvm/pull/10493#issuecomment-1061841449
> Can you explain what you mean? I think I've made this pretty generic? You moved only the Hexagon include into a different place. If that's because only Hexagon uses log customization, then this isn't very generic. If some other target wants to customize logs as well, their include would need to be moved too. Not only that, but the corresponding cmake file would need to be modified quite a bit to use the actual targets (like `tvm_runtime_objs`) instead of variables. The custom logging should only apply when building for Hexagon. According to your comment, the issue here is that it's turned on when building for other targets as well. The first thing to do would be to turn it off in Hexagon to eliminate the immediate problem (which it what I suggested in my first comment). Then we can figure out how to deal with the actual issue of log customization. I'm fine with having it "broken" within Hexagon for now, if it fixes the issue you mentioned first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
