Lunderberg commented on a change in pull request #10586:
URL: https://github.com/apache/tvm/pull/10586#discussion_r825967148
##########
File path: src/target/llvm/codegen_llvm.cc
##########
@@ -1274,39 +1278,56 @@ bool CodeGenLLVM::HasAlignmentPadding(DataType dtype) {
}
void CodeGenLLVM::BufferAccessHelper(
- Buffer buffer, PrimExpr index, DataType value_dtype,
+ Buffer buffer, Array<PrimExpr> indices, DataType value_dtype,
std::function<llvm::Instruction*(TypedPointer buffer_ptr, int
subelement_i, int alignment,
bool is_volatile)>
make_instruction) {
DataType buffer_element_dtype = buffer->dtype;
- ICHECK_EQ(value_dtype.lanes(), index.dtype().lanes() *
buffer_element_dtype.lanes());
+ // Only the last index is allowed to be multi-lane. All earlier
+ // indices must be scalar. This only matters for subclasses of
+ // CodeGenLLVM, because the default implementation of GetBufferPtr
+ // requires 1-d indices.
+ std::vector<llvm::Value*> earlier_index_values;
+ for (size_t i = 0; i < indices.size() - 1; i++) {
+ ICHECK_EQ(indices[i].dtype().lanes(), 1)
+ << "Buffer " << buffer->name << " is accessed with a multi-lane index
at position " << i
+ << ". Multi-lane indices are only supported as the last index.";
+ earlier_index_values.push_back(MakeValue(indices[i]));
+ }
+
+ ICHECK_GE(indices.size(), 1)
Review comment:
Thank you for the catch, and updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
