csullivan commented on a change in pull request #10586:
URL: https://github.com/apache/tvm/pull/10586#discussion_r826400777
##########
File path: src/tir/transforms/storage_flatten.cc
##########
@@ -1357,7 +1427,8 @@ class StorageFlattener : public StmtExprMutator {
}
e.buffer = Buffer(op->buffer->data, op->buffer->dtype,
op->buffer->shape, op->buffer->strides,
- PrimExpr(), op->buffer->name, align, 0, kDefault);
+ PrimExpr(), op->buffer->name, align, 0, kDefault,
+ op->buffer->axis_separators, op->buffer->span);
Review comment:
Were the StorageFlatten changes missed in #9727 and being added here now
that we are integrating with codegen and your test caught an issue?
I was initially confused why storage flatten needs a change here but ⬆️ is
my guess now. If not can you comment on the issue? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
