Lunderberg commented on a change in pull request #10586:
URL: https://github.com/apache/tvm/pull/10586#discussion_r825980724
##########
File path: src/target/llvm/codegen_hexagon.cc
##########
@@ -76,6 +76,8 @@ class CodeGenHexagon final : public CodeGenLLVM {
llvm::FunctionType* ftype_tvm_api_set_last_error_{nullptr};
private:
+ TypedPointer CreateBufferPtr(llvm::Value* buffer_ptr, DataType
buffer_element_dtype,
+ std::vector<llvm::Value*> indices, DataType
value_dtype) final;
Review comment:
Thank you, and I hadn't been aware of `llvm::ArrayRef`. Updated as
recommended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
