Lunderberg commented on a change in pull request #10586:
URL: https://github.com/apache/tvm/pull/10586#discussion_r826980281
##########
File path: src/tir/transforms/storage_flatten.cc
##########
@@ -1357,7 +1427,8 @@ class StorageFlattener : public StmtExprMutator {
}
e.buffer = Buffer(op->buffer->data, op->buffer->dtype,
op->buffer->shape, op->buffer->strides,
- PrimExpr(), op->buffer->name, align, 0, kDefault);
+ PrimExpr(), op->buffer->name, align, 0, kDefault,
+ op->buffer->axis_separators, op->buffer->span);
Review comment:
That's correct, the changes to storage flatten are bugfixes that were
exposed by these additional tests at the codegen level. Here, the
`axis_separators` failed to be passed through to the buffer with alignment, and
earlier in the file the `IndexMap` failed to be updated when the buffer objects
were modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
