Mousius commented on PR #11327: URL: https://github.com/apache/tvm/pull/11327#issuecomment-1134871269
> For me, seeing a series of `N` if-statements says that there are `2^N` possible paths for control flow, and that they should each be considered, where a if/elif chain with `N` blocks says that there are `N` possible paths for control flow. This is a good example of where the ask here is personalised to your way of writing code, gradually over time the end result of this would be removal of all linter rules to allow everyone to write code in their preferred way. > I'd like to wait another day or two to make sure the reply addresses @Mousius 's concerns. Other than that, yes. I was voicing my concerns as I think slowly making our code less consistent is a bad idea. In line with the [Code Review Guidelines](https://tvm.apache.org/docs/contribute/code_review.html#approve-and-request-changes-explicitly), I'm not explicitly requesting a change here, merely leaving a comment for consideration of the committer who takes responsibility in merging this 😸 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
