csullivan commented on code in PR #11635:
URL: https://github.com/apache/tvm/pull/11635#discussion_r893864179
##########
cmake/modules/Hexagon.cmake:
##########
@@ -116,7 +116,7 @@ function(add_hexagon_wrapper_paths)
link_directories("${HEXAGON_TOOLCHAIN}/lib/iss")
endfunction()
-if(BUILD_FOR_HEXAGON OR USE_HEXAGON_RPC)
+if(BUILD_FOR_HEXAGON OR ("${USE_HEXAGON_RPC}" STREQUAL "HEXAGON"))
Review Comment:
BUILD_FOR_HEXAGON is false for the runtime android and x86 build targeted by
the hexagon_api, and USE_HEXAGON_RPC is true for these cases. Thus I want to
tighten the requirement so that hexagon sources are not brought in to the
tvm_runtime builds (initiated by the hexagon_api cmake) when we aren't building
for hexagon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
