adstraw commented on code in PR #11635:
URL: https://github.com/apache/tvm/pull/11635#discussion_r894932083
##########
cmake/modules/Hexagon.cmake:
##########
@@ -116,7 +116,7 @@ function(add_hexagon_wrapper_paths)
link_directories("${HEXAGON_TOOLCHAIN}/lib/iss")
endfunction()
-if(BUILD_FOR_HEXAGON OR USE_HEXAGON_RPC)
+if(BUILD_FOR_HEXAGON OR ("${USE_HEXAGON_RPC}" STREQUAL "HEXAGON"))
Review Comment:
I am getting some strange results if I fail to set `USE_HEXAGON_RPC` for the
x86/Android builds. For Android, there is a linker error. For x86, some sort
of runtime simulation error. I did not spend time to debug these errors.
However, I can revert the changes to `hexagon_api/CMakeLists.txt` and just
set `USE_HEXAGON_RPC=ON` for all three builds while checking for
`if(BUILD_FOR_HEXAGON)` in Hexagon.cmake and it appears to work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
