adstraw commented on code in PR #11635:
URL: https://github.com/apache/tvm/pull/11635#discussion_r894936088
##########
cmake/modules/Hexagon.cmake:
##########
@@ -116,7 +116,7 @@ function(add_hexagon_wrapper_paths)
link_directories("${HEXAGON_TOOLCHAIN}/lib/iss")
endfunction()
-if(BUILD_FOR_HEXAGON OR USE_HEXAGON_RPC)
+if(BUILD_FOR_HEXAGON OR ("${USE_HEXAGON_RPC}" STREQUAL "HEXAGON"))
Review Comment:
We may be able to "remove `USE_HEXAGON_RPC` from x86/android builds" in
`hexagon_api/CMakeLists.txt` as @kparzysz-quic but I am getting some strange
results when doing so. I reverted the changes to that file in this PR.
Changing to `if(BUILD_FOR_HEXAGON)` and removing the API check works and
accomplishes the original intent of the PR.
##########
cmake/modules/Hexagon.cmake:
##########
@@ -116,7 +116,7 @@ function(add_hexagon_wrapper_paths)
link_directories("${HEXAGON_TOOLCHAIN}/lib/iss")
endfunction()
-if(BUILD_FOR_HEXAGON OR USE_HEXAGON_RPC)
+if(BUILD_FOR_HEXAGON OR ("${USE_HEXAGON_RPC}" STREQUAL "HEXAGON"))
Review Comment:
We may be able to "remove `USE_HEXAGON_RPC` from x86/android builds" in
`hexagon_api/CMakeLists.txt` as @kparzysz-quic suggests but I am getting some
strange results when doing so. I reverted the changes to that file in this PR.
Changing to `if(BUILD_FOR_HEXAGON)` and removing the API check works and
accomplishes the original intent of the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
