kparzysz-quic commented on code in PR #11635:
URL: https://github.com/apache/tvm/pull/11635#discussion_r893873916
##########
cmake/modules/Hexagon.cmake:
##########
@@ -116,7 +116,7 @@ function(add_hexagon_wrapper_paths)
link_directories("${HEXAGON_TOOLCHAIN}/lib/iss")
endfunction()
-if(BUILD_FOR_HEXAGON OR USE_HEXAGON_RPC)
+if(BUILD_FOR_HEXAGON OR ("${USE_HEXAGON_RPC}" STREQUAL "HEXAGON"))
Review Comment:
What I mean is that it seems that `(${USE_HEXAGON_RPC} == "HEXAGON") =>
BUILD_FOR_HEXAGON`. Unless I'm missing something, you can just remove
`USE_HEXAGON_RPC` from x86/android builds (and also from this check).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
