NicolaLancellotti commented on code in PR #13643:
URL: https://github.com/apache/tvm/pull/13643#discussion_r1060438817
##########
apps/microtvm/cmsisnn/Makefile:
##########
@@ -69,6 +69,18 @@ $(BUILD_DIR)/crt_backend_api.o:
$(STANDALONE_CRT_PATH)/src/runtime/crt/common/cr
$(QUIET)mkdir -p $(@D)
$(QUIET)$(CC) -c $(PKG_CFLAGS) -o $@ $^
+$(BUILD_DIR)/crt_runtime_api.o:
$(STANDALONE_CRT_PATH)/src/runtime/crt/common/crt_runtime_api.c
+ $(QUIET)mkdir -p $(@D)
+ $(QUIET)$(CC) -c $(PKG_CFLAGS) -o $@ $^
+
+$(BUILD_DIR)/func_registry.o:
$(STANDALONE_CRT_PATH)/src/runtime/crt/common/func_registry.c
+ $(QUIET)mkdir -p $(@D)
+ $(QUIET)$(CC) -c $(PKG_CFLAGS) -o $@ $^
+
+$(BUILD_DIR)/ndarray.o: $(STANDALONE_CRT_PATH)/src/runtime/crt/common/ndarray.c
+ $(QUIET)mkdir -p $(@D)
+ $(QUIET)$(CC) -c $(PKG_CFLAGS) -o $@ $^
+
Review Comment:
Yes, they are dependencies for `crt_runtime_api.c` which defines
`TVMAPISetLastError` and `TVMGetLastError`.
Instead of depending on `crt_runtime_api.c` we can generate the definitions
of these functions as @ashutosh-arm thought:
https://github.com/apache/tvm/pull/13643#discussion_r1052140042, what do you
think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
