NicolaLancellotti commented on code in PR #13643:
URL: https://github.com/apache/tvm/pull/13643#discussion_r1060750863
##########
apps/microtvm/cmsisnn/Makefile:
##########
@@ -69,6 +69,18 @@ $(BUILD_DIR)/crt_backend_api.o:
$(STANDALONE_CRT_PATH)/src/runtime/crt/common/cr
$(QUIET)mkdir -p $(@D)
$(QUIET)$(CC) -c $(PKG_CFLAGS) -o $@ $^
+$(BUILD_DIR)/crt_runtime_api.o:
$(STANDALONE_CRT_PATH)/src/runtime/crt/common/crt_runtime_api.c
+ $(QUIET)mkdir -p $(@D)
+ $(QUIET)$(CC) -c $(PKG_CFLAGS) -o $@ $^
+
+$(BUILD_DIR)/func_registry.o:
$(STANDALONE_CRT_PATH)/src/runtime/crt/common/func_registry.c
+ $(QUIET)mkdir -p $(@D)
+ $(QUIET)$(CC) -c $(PKG_CFLAGS) -o $@ $^
+
+$(BUILD_DIR)/ndarray.o: $(STANDALONE_CRT_PATH)/src/runtime/crt/common/ndarray.c
+ $(QUIET)mkdir -p $(@D)
+ $(QUIET)$(CC) -c $(PKG_CFLAGS) -o $@ $^
+
Review Comment:
I am not sure I understood, can you elaborate?
In this pr, we save the error through `TVMAPISetLastError` and then we
retrieve it through `TVMGetLastError`, so we need the definitions of these two
functions.
In the current implementation the functions are defined in
`crt_runtime_api.c`, the problem is that this file has other functions, which
we do not use, that depend on functions defined in `func_registry.c` and
`ndarray.c`.
Ashutosh proposed not to use the definitions in `crt_runtime_api.c`, but to
just emit the definitions of these two functions in `aot.py`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
