Mousius commented on code in PR #13643:
URL: https://github.com/apache/tvm/pull/13643#discussion_r1061728070
##########
apps/microtvm/cmsisnn/Makefile:
##########
@@ -69,6 +69,18 @@ $(BUILD_DIR)/crt_backend_api.o:
$(STANDALONE_CRT_PATH)/src/runtime/crt/common/cr
$(QUIET)mkdir -p $(@D)
$(QUIET)$(CC) -c $(PKG_CFLAGS) -o $@ $^
+$(BUILD_DIR)/crt_runtime_api.o:
$(STANDALONE_CRT_PATH)/src/runtime/crt/common/crt_runtime_api.c
+ $(QUIET)mkdir -p $(@D)
+ $(QUIET)$(CC) -c $(PKG_CFLAGS) -o $@ $^
+
+$(BUILD_DIR)/func_registry.o:
$(STANDALONE_CRT_PATH)/src/runtime/crt/common/func_registry.c
+ $(QUIET)mkdir -p $(@D)
+ $(QUIET)$(CC) -c $(PKG_CFLAGS) -o $@ $^
+
+$(BUILD_DIR)/ndarray.o: $(STANDALONE_CRT_PATH)/src/runtime/crt/common/ndarray.c
+ $(QUIET)mkdir -p $(@D)
+ $(QUIET)$(CC) -c $(PKG_CFLAGS) -o $@ $^
+
Review Comment:
There are two separate issues here:
1. The C Runtime doesn't make it easy to use only the bits you want so you
suddenly need array handling if you want error handling - this is a future
problem if we want to tackle it
2. If we emit calls to these functions we're breaking anyone who currently
compiles their model with CMSIS-NN - we need to have a way for users to specify
that they don't want the debugging behaviour and then we don't emit the calls
to the `TVMAPISetLastError`/`TVMAPIGetLastError` apis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
