slyubomirsky commented on code in PR #14394:
URL: https://github.com/apache/tvm/pull/14394#discussion_r1169031291
##########
src/relax/op/op.cc:
##########
@@ -450,7 +538,9 @@
TVM_REGISTER_GLOBAL("relax.op.memory.alloc_tensor").set_body_typed(MakeMemAllocT
RELAY_REGISTER_OP("relax.memory.kill_storage")
.set_num_inputs(1)
.add_argument("storage", "Expr", "The storage to be killed.")
- .set_attr<FInferStructInfo>("FInferStructInfo", ReturnVoidStructInfo);
+ .set_attr<FInferStructInfo>("FInferStructInfo", ReturnVoidStructInfo)
+ // deallocation also isn't considered a "visible effect" as far as purity
is concerned
+ .set_attr<Bool>("FPurity", Bool(false));
Review Comment:
Oops, will fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
