[ 
https://issues.apache.org/jira/browse/WICKET-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132815#comment-13132815
 ] 

Bertrand Guay-Paquet commented on WICKET-4153:
----------------------------------------------

Please see the attached screenshots to see the problem. The borders are not 
rendered properly with an empty tbody section.

I am not particularly fond of the bogus row made invisible with CSS either. 
However, it does produce valid HTML. Adding a no-records row in tbody instead 
of tfoot would be a better solution. Would there still be problems with that 
solution? It would of course make the no-records toolbar mandatory to produce 
valid markup.

@Sven: I disagree with your comment about HTML5. It is not even a finished 
standard yet and it is definitely not widely supported by browsers yet. 
Ignoring the HTML4 problem because HTML5 relaxes the rules is not acceptable. 
Firefox renders HTML5 and it fails to render tables properly with an empty 
tbody.

@Sander: In theory, browsers can repeat thead and tfoot sections for long tbody 
sections. I believe it also provides better context for screen readers as well.
                
> The tbody section of a DataTable is empty when no records are returned by the 
> provider.
> ---------------------------------------------------------------------------------------
>
>                 Key: WICKET-4153
>                 URL: https://issues.apache.org/jira/browse/WICKET-4153
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>    Affects Versions: 1.5.1
>            Reporter: Bertrand Guay-Paquet
>            Assignee: Sven Meier
>            Priority: Trivial
>              Labels: datatable
>             Fix For: 1.5.3
>
>         Attachments: DataTable.patch, good.png, with_patch.png, 
> without_patch.png
>
>
> When a DataTable is rendered without records, the tbody section is empty. 
> This violates the html spec.
> From the spec:
> "When present, each THEAD, TFOOT, and TBODY contains a row group. Each row 
> group must contain at least one row, defined by the TR element."
> and
> "The THEAD, TFOOT, and TBODY sections must contain the same number of 
> columns."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to