[ 
https://issues.apache.org/jira/browse/WICKET-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133017#comment-13133017
 ] 

Bertrand Guay-Paquet commented on WICKET-4153:
----------------------------------------------

The screenshots shots that the problem is not the border around the whole 
table, but the border around <thead> and between <th> elements in the <thead> 
section. Maybe I did not understand your suggestion correctly, but an 
additional wrapping div would solve all these problems.

Good point though regarding the javascript looking for tr elements.

Semantically, IMHO the best we could do is put the "no records" row in tbody 
instead of tfoot (with proper colspan and maybe css). However, that would be a 
more involved fix and would bring back the javascript-looking-for-tr problem...
                
> The tbody section of a DataTable is empty when no records are returned by the 
> provider.
> ---------------------------------------------------------------------------------------
>
>                 Key: WICKET-4153
>                 URL: https://issues.apache.org/jira/browse/WICKET-4153
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>    Affects Versions: 1.5.1
>            Reporter: Bertrand Guay-Paquet
>            Priority: Trivial
>              Labels: datatable
>             Fix For: 1.5.3
>
>         Attachments: DataTable.patch, good.png, with_patch.png, 
> without_patch.png
>
>
> When a DataTable is rendered without records, the tbody section is empty. 
> This violates the html spec.
> From the spec:
> "When present, each THEAD, TFOOT, and TBODY contains a row group. Each row 
> group must contain at least one row, defined by the TR element."
> and
> "The THEAD, TFOOT, and TBODY sections must contain the same number of 
> columns."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to