[ 
https://issues.apache.org/jira/browse/WICKET-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132997#comment-13132997
 ] 

Sven Meier commented on WICKET-4153:
------------------------------------

@Sander
The ticket is still open because I reverted my changes, thus we don't have an 
agreed fix yet. Note that according to the spec a table must have a tbody 
element and no direct tr children.

@Bertrand
IMHO accessibility is the strongest point *against* an invisble row, it would 
destroy the semantics of the table.
Furthermore what about javascript methods that look for tr elements (e.g. a 
drag and drop solution)?

w3c probably noticed their mistake in making a tr inside tbody mandatory and 
fixed their decision in HTML5. Firefox' border-bug can easily be bypassed with 
an additional wrapping div. That's what the CSS designers do all the time 
anyway.

That's my take on this issue, I don't approve your patch. You may convince 
another dev to follow your arguments.

Thanks for your dedication on this issue.
                
> The tbody section of a DataTable is empty when no records are returned by the 
> provider.
> ---------------------------------------------------------------------------------------
>
>                 Key: WICKET-4153
>                 URL: https://issues.apache.org/jira/browse/WICKET-4153
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>    Affects Versions: 1.5.1
>            Reporter: Bertrand Guay-Paquet
>            Assignee: Sven Meier
>            Priority: Trivial
>              Labels: datatable
>             Fix For: 1.5.3
>
>         Attachments: DataTable.patch, good.png, with_patch.png, 
> without_patch.png
>
>
> When a DataTable is rendered without records, the tbody section is empty. 
> This violates the html spec.
> From the spec:
> "When present, each THEAD, TFOOT, and TBODY contains a row group. Each row 
> group must contain at least one row, defined by the TR element."
> and
> "The THEAD, TFOOT, and TBODY sections must contain the same number of 
> columns."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to