Repository: wicket
Updated Branches:
  refs/heads/master 6797b35c0 -> c24d830cd


WICKET-5643 storeBufferedResponse should check if session is temporary.

added a check for session id and some JavaDoc

Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/c24d830c
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/c24d830c
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/c24d830c

Branch: refs/heads/master
Commit: c24d830cd5dda3f85d305537201f45e57f403c97
Parents: 6797b35
Author: andrea del bene <[email protected]>
Authored: Wed Jul 16 19:29:28 2014 +0200
Committer: andrea del bene <[email protected]>
Committed: Wed Jul 16 19:29:28 2014 +0200

----------------------------------------------------------------------
 .../java/org/apache/wicket/protocol/http/WebApplication.java  | 7 +++++++
 1 file changed, 7 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/c24d830c/wicket-core/src/main/java/org/apache/wicket/protocol/http/WebApplication.java
----------------------------------------------------------------------
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/protocol/http/WebApplication.java 
b/wicket-core/src/main/java/org/apache/wicket/protocol/http/WebApplication.java
index 988243a..65b42ca 100644
--- 
a/wicket-core/src/main/java/org/apache/wicket/protocol/http/WebApplication.java
+++ 
b/wicket-core/src/main/java/org/apache/wicket/protocol/http/WebApplication.java
@@ -888,6 +888,8 @@ public abstract class WebApplication extends Application
        }
 
        /**
+        * Store the buffered response at application level to use it at a 
later time.
+        * NOTE: the method requires a not-null session id, otherwise it just 
returns.
         * 
         * @param sessionId
         * @param url
@@ -895,6 +897,11 @@ public abstract class WebApplication extends Application
         */
        public void storeBufferedResponse(String sessionId, Url url, 
BufferedWebResponse response)
        {
+               if (sessionId == null) 
+               {
+                       return;
+               }
+               
                String key = sessionId + url.toString();
                storedResponses.put(key, response);
        }

Reply via email to