Repository: wicket
Updated Branches:
  refs/heads/wicket-6.x c95d8f74c -> 0c79489b9


WICKET-5643 storeBufferedResponse should check if session is temporary.

added a check for session id and some JavaDoc


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/0c79489b
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/0c79489b
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/0c79489b

Branch: refs/heads/wicket-6.x
Commit: 0c79489b9c70a5d442b42fdb61b0384fa66065e4
Parents: c95d8f7
Author: andrea del bene <[email protected]>
Authored: Wed Jul 16 19:29:28 2014 +0200
Committer: andrea del bene <[email protected]>
Committed: Wed Jul 16 19:54:50 2014 +0200

----------------------------------------------------------------------
 .../java/org/apache/wicket/protocol/http/WebApplication.java  | 7 +++++++
 1 file changed, 7 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/0c79489b/wicket-core/src/main/java/org/apache/wicket/protocol/http/WebApplication.java
----------------------------------------------------------------------
diff --git 
a/wicket-core/src/main/java/org/apache/wicket/protocol/http/WebApplication.java 
b/wicket-core/src/main/java/org/apache/wicket/protocol/http/WebApplication.java
index ddd7cd3..7473041 100644
--- 
a/wicket-core/src/main/java/org/apache/wicket/protocol/http/WebApplication.java
+++ 
b/wicket-core/src/main/java/org/apache/wicket/protocol/http/WebApplication.java
@@ -885,6 +885,8 @@ public abstract class WebApplication extends Application
        }
 
        /**
+        * Store the buffered response at application level to use it at a 
later time.
+        * NOTE: the method requires a not-null session id, otherwise it just 
returns.
         * 
         * @param sessionId
         * @param url
@@ -892,6 +894,11 @@ public abstract class WebApplication extends Application
         */
        public void storeBufferedResponse(String sessionId, Url url, 
BufferedWebResponse response)
        {
+               if (sessionId == null) 
+               {
+                       return;
+               }
+               
                String key = sessionId + url.toString();
                storedResponses.put(key, response);
        }

Reply via email to