Repository: wicket Updated Branches: refs/heads/wicket-6.x 6b8439f93 -> f95e3130b
WICKET-5643 storeBufferedResponse should check if session is temporary. Revert 1064d372b48a048bdee292564ec5f45cd00fd3c4 by adelbene Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/f95e3130 Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/f95e3130 Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/f95e3130 Branch: refs/heads/wicket-6.x Commit: f95e3130b1a0b9d40e77f90f2bf869d21fd851e0 Parents: 6b8439f Author: Martin Tzvetanov Grigorov <[email protected]> Authored: Mon Jul 28 12:30:06 2014 +0300 Committer: Martin Tzvetanov Grigorov <[email protected]> Committed: Mon Jul 28 12:30:06 2014 +0300 ---------------------------------------------------------------------- .../java/org/apache/wicket/protocol/http/WebApplication.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/wicket/blob/f95e3130/wicket-core/src/main/java/org/apache/wicket/protocol/http/WebApplication.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/main/java/org/apache/wicket/protocol/http/WebApplication.java b/wicket-core/src/main/java/org/apache/wicket/protocol/http/WebApplication.java index dff0777..1123e8a 100644 --- a/wicket-core/src/main/java/org/apache/wicket/protocol/http/WebApplication.java +++ b/wicket-core/src/main/java/org/apache/wicket/protocol/http/WebApplication.java @@ -893,12 +893,13 @@ public abstract class WebApplication extends Application */ public void storeBufferedResponse(String sessionId, Url url, BufferedWebResponse response) { - if (sessionId == null) + if (Strings.isEmpty(sessionId)) { - log.warn("storeBufferedResponse needs a valid session id to store the response, but a null one was found. " + log.error("storeBufferedResponse needs a valid session id to store the response, but a null one was found. " + "Please report the problem to dev team and try to reproduce it in a quickstart project."); + return; } - + String key = sessionId + url.toString(); storedResponses.put(key, response); }
