Repository: wicket Updated Branches: refs/heads/master f1893e7dc -> dc635f936
WICKET-5643 storeBufferedResponse should check if session is temporary. Code changed as suggested by Martin Project: http://git-wip-us.apache.org/repos/asf/wicket/repo Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/dc635f93 Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/dc635f93 Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/dc635f93 Branch: refs/heads/master Commit: dc635f936ea6050d3327659a047e30fa386da853 Parents: f1893e7 Author: andrea del bene <[email protected]> Authored: Thu Jul 17 20:22:35 2014 +0200 Committer: andrea del bene <[email protected]> Committed: Thu Jul 17 20:22:35 2014 +0200 ---------------------------------------------------------------------- .../org/apache/wicket/protocol/http/WebApplication.java | 8 +------- .../wicket/request/handler/render/WebPageRenderer.java | 9 ++++++++- 2 files changed, 9 insertions(+), 8 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/wicket/blob/dc635f93/wicket-core/src/main/java/org/apache/wicket/protocol/http/WebApplication.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/main/java/org/apache/wicket/protocol/http/WebApplication.java b/wicket-core/src/main/java/org/apache/wicket/protocol/http/WebApplication.java index 65b42ca..5dda241 100644 --- a/wicket-core/src/main/java/org/apache/wicket/protocol/http/WebApplication.java +++ b/wicket-core/src/main/java/org/apache/wicket/protocol/http/WebApplication.java @@ -889,19 +889,13 @@ public abstract class WebApplication extends Application /** * Store the buffered response at application level to use it at a later time. - * NOTE: the method requires a not-null session id, otherwise it just returns. - * + * * @param sessionId * @param url * @param response */ public void storeBufferedResponse(String sessionId, Url url, BufferedWebResponse response) { - if (sessionId == null) - { - return; - } - String key = sessionId + url.toString(); storedResponses.put(key, response); } http://git-wip-us.apache.org/repos/asf/wicket/blob/dc635f93/wicket-core/src/main/java/org/apache/wicket/request/handler/render/WebPageRenderer.java ---------------------------------------------------------------------- diff --git a/wicket-core/src/main/java/org/apache/wicket/request/handler/render/WebPageRenderer.java b/wicket-core/src/main/java/org/apache/wicket/request/handler/render/WebPageRenderer.java index af9dbee..a89f8bc 100644 --- a/wicket-core/src/main/java/org/apache/wicket/request/handler/render/WebPageRenderer.java +++ b/wicket-core/src/main/java/org/apache/wicket/request/handler/render/WebPageRenderer.java @@ -71,12 +71,19 @@ public class WebPageRenderer extends PageRenderer } /** + * Store the buffered response at application level. If current session is + * temporary, a permanent one is created. * * @param url * @param response */ protected void storeBufferedResponse(Url url, BufferedWebResponse response) - { + { + if (isSessionTemporary()) + { + Session.get().bind(); + } + WebApplication.get().storeBufferedResponse(getSessionId(), url, response); }
