[ 
https://issues.apache.org/jira/browse/WICKET-5735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14186557#comment-14186557
 ] 

ASF GitHub Bot commented on WICKET-5735:
----------------------------------------

Github user martin-g commented on a diff in the pull request:

    https://github.com/apache/wicket/pull/79#discussion_r19457135
  
    --- Diff: 
wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java ---
    @@ -574,7 +567,15 @@ public void component(Form<?> component, IVisit<Bytes> 
visit)
                return maxSize[0];
        }
     
    -   /**
    +    /**
    --- End diff --
    
    same here (and below)


> Propagate fileSizeMax attribute to 
> org.apache.commons.fileupload.FileUploadBase
> -------------------------------------------------------------------------------
>
>                 Key: WICKET-5735
>                 URL: https://issues.apache.org/jira/browse/WICKET-5735
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Roman Grigoriadi
>            Priority: Minor
>
> Wicket's MultipartServletWebRequestImpl uses commons ServletFileUpload 
> internally, but there is no way to configure this component, for example to 
> propagate fileSizeMax inside.
> As supposed in 
> http://apache-wicket.1842946.n4.nabble.com/org-apache-wicket-util-upload-FileUploadBase-fileSizeMax-td4668001.html
>  there should be implemented:
> 1) add Form#fileSizeMax and pass it to MultipartServletWebRequest 
> 2) add MultipartServletWebRequestImpl#newFileUpload(FileItemFactory) 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to