[ https://issues.apache.org/jira/browse/WICKET-5735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14186565#comment-14186565 ]
ASF GitHub Bot commented on WICKET-5735: ---------------------------------------- Github user martin-g commented on a diff in the pull request: https://github.com/apache/wicket/pull/79#discussion_r19457322 --- Diff: wicket-core/src/main/java/org/apache/wicket/protocol/http/servlet/ServletWebRequest.java --- @@ -49,6 +34,12 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import javax.servlet.http.Cookie; +import javax.servlet.http.HttpServletRequest; +import javax.servlet.http.HttpServletResponse; +import java.nio.charset.Charset; +import java.util.*; --- End diff -- I'll fix those. We don't like `*` imports > Propagate fileSizeMax attribute to > org.apache.commons.fileupload.FileUploadBase > ------------------------------------------------------------------------------- > > Key: WICKET-5735 > URL: https://issues.apache.org/jira/browse/WICKET-5735 > Project: Wicket > Issue Type: Improvement > Components: wicket > Reporter: Roman Grigoriadi > Priority: Minor > > Wicket's MultipartServletWebRequestImpl uses commons ServletFileUpload > internally, but there is no way to configure this component, for example to > propagate fileSizeMax inside. > As supposed in > http://apache-wicket.1842946.n4.nabble.com/org-apache-wicket-util-upload-FileUploadBase-fileSizeMax-td4668001.html > there should be implemented: > 1) add Form#fileSizeMax and pass it to MultipartServletWebRequest > 2) add MultipartServletWebRequestImpl#newFileUpload(FileItemFactory) -- This message was sent by Atlassian JIRA (v6.3.4#6332)