[
https://issues.apache.org/jira/browse/WICKET-5735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14186558#comment-14186558
]
ASF GitHub Bot commented on WICKET-5735:
----------------------------------------
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/79#discussion_r19457202
--- Diff:
wicket-core/src/main/java/org/apache/wicket/protocol/http/servlet/MultipartServletWebRequestImpl.java
---
@@ -88,9 +87,9 @@
* Thrown if something goes wrong with upload
*/
public MultipartServletWebRequestImpl(HttpServletRequest request,
String filterPrefix,
- Bytes maxSize, String upload) throws FileUploadException
+ Bytes maxSize, Bytes fileMaxSize, String upload) throws
FileUploadException
--- End diff --
we will need a new constructor here because adding new parameters will
break the backward compatibility.
preserve the old constructor(s) and pass `null` as a value for
`fileMaxSize` to the new one(s)
> Propagate fileSizeMax attribute to
> org.apache.commons.fileupload.FileUploadBase
> -------------------------------------------------------------------------------
>
> Key: WICKET-5735
> URL: https://issues.apache.org/jira/browse/WICKET-5735
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Reporter: Roman Grigoriadi
> Priority: Minor
>
> Wicket's MultipartServletWebRequestImpl uses commons ServletFileUpload
> internally, but there is no way to configure this component, for example to
> propagate fileSizeMax inside.
> As supposed in
> http://apache-wicket.1842946.n4.nabble.com/org-apache-wicket-util-upload-FileUploadBase-fileSizeMax-td4668001.html
> there should be implemented:
> 1) add Form#fileSizeMax and pass it to MultipartServletWebRequest
> 2) add MultipartServletWebRequestImpl#newFileUpload(FileItemFactory)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
