slachiewicz commented on PR #897: URL: https://github.com/apache/incubator-xtable/pull/897#issuecomment-5370207264
`jdeps` on the built jar found a gap the earlier analysis missed, fixed in 16778bb. `s3` and `sts` pull `arns`, `aws-query-protocol`, `aws-xml-protocol` and `crt-core`. All four were in the old `bundle`, but the shade `<artifactSet><includes>` is an explicit whitelist, so naming `s3` as a dependency is not enough — every transitive artifact has to be listed or shade drops it. The S3 and STS clients would have failed at runtime. Also: `hadoop-aws` brings `software.amazon.awssdk:bundle:2.24.6` transitively. The direct 2.29.40 declaration had been masking it, so removing that let an older fat bundle back into the tree. Now excluded explicitly. After the fix the package counts match the original bundle exactly — `arns` 9, `protocols/xml` 67, `protocols/query` 50, `services/s3/transform` 99, `services/sts` 357 — and nothing in the runtime tree is left unwhitelisted. Jar stays at 423 MB. One thing `jdeps` flags that is not a regression: `software.amazon.awssdk.crt.*`. The AWS Common Runtime is a separate `software.amazon.awssdk.crt:aws-crt` artifact, absent from `bundle` as well, so XTable has never shipped it. Unchanged by this PR. The live S3 run is still worth doing before merge. *This comment was created with AI assistance.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
