slachiewicz commented on code in PR #897:
URL: https://github.com/apache/incubator-xtable/pull/897#discussion_r3835773502
##########
xtable-utilities/pom.xml:
##########
@@ -215,10 +215,30 @@
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-aws</artifactId>
+ <exclusions>
+ <!-- The all-services SDK jar. We name the artifacts S3A uses
instead. -->
+ <exclusion>
+ <groupId>software.amazon.awssdk</groupId>
+ <artifactId>bundle</artifactId>
+ </exclusion>
+ </exclusions>
</dependency>
+ <!-- What hadoop-aws S3A needs. The all-services `bundle` artifact was
63% of the shaded jar. -->
<dependency>
<groupId>software.amazon.awssdk</groupId>
- <artifactId>bundle</artifactId>
+ <artifactId>s3</artifactId>
Review Comment:
Thanks for scoping this — the priority order matches mine.
I'll try to recreate the doc flows, starting with `how-to.md` against a real
S3 bucket with shipped defaults, and report which of the four I can reach. If
you can pick up any of the rest in the meantime, even better.
On 3: `grpc-xds` is loaded reflectively through grpc's name-resolver
registry, only for `xds:` targets, so the default JSON path never touches it —
which matches your read that `fs.gs.grpc.enable=false` is safe. I'd keep the
drop and document `fs.gs.grpc.enable=true` as unsupported in the slim jar — the
same posture this PR already takes for `fs.s3a.aws.credentials.provider` values
naming dropped SDK classes. A user opting into the experimental gRPC path can
add `grpc-xds` to the classpath.
*This comment was created with AI assistance.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
