slachiewicz commented on PR #897:
URL: https://github.com/apache/incubator-xtable/pull/897#issuecomment-5699135640

   Both findings confirmed, and fixed in 
[0ee1501](https://github.com/apache/incubator-xtable/commit/0ee15019c0d2b8fa62ad4bd8f7ce6d5f4c17a5d3),
 rebased onto `main` past #923.
   
   Your filter alone left a second gap. hadoop-aws also calls 
`ApacheHttpClient.Builder.socketFactory` with the relocated 
`ConnectionSocketFactory` type from `ConfigureShadedAWSSocketFactory`, and the 
standalone `apache-client` has the unrelocated signature. `NetworkBinding` 
catches the `LinkageError` and logs "value of fs.s3a.ssl.channel.mode will be 
ignored" on every S3A init. So the bundle filter takes 
`software/amazon/awssdk/http/apache/**` as well, plus the relocated 
commons-logging, commons-codec and slf4j that client calls, and the standalone 
`apache-client` leaves the whitelist. Everything is at 2.29.40 through the BOM, 
so no class ships twice. `grpc-xds` is back.
   
   Verified: against the built jar, `STSClientFactory.builder(...)` with an 
explicit endpoint → `StsException` (403); 
`ConfigureShadedAWSSocketFactory.configureSocketFactory` → no error. Jar is 
437,879,673 bytes.
   
   *This comment was created with AI assistance.*
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to