slachiewicz commented on code in PR #897:
URL: https://github.com/apache/incubator-xtable/pull/897#discussion_r3950980055
##########
pom.xml:
##########
@@ -674,6 +670,10 @@
<exclude>META-INF/*.DSA</exclude>
<exclude>META-INF/*.RSA</exclude>
<exclude>**/Log4j2Plugins.dat</exclude>
+ <!-- RocksDB natives for platforms
we do not run on. -->
Review Comment:
Measured, so you can weigh it: the three globs drop six files, 28.7 MB
compressed (82.0 MB uncompressed). Dropping the excludes puts the jar at
roughly 452 MB instead of 423 MB, so the PR's main result survives either way.
| Kept | Dropped |
|---|---|
| `linux64`, `linux64-musl`, `linux-aarch64`, `linux-aarch64-musl`,
`osx-x86_64`, `osx-arm64`, `win64` | `linux-ppc64le`, `linux-ppc64le-musl`,
`linux-s390x`, `linux-s390x-musl`, `linux32`, `linux32-musl` |
What a user on ppc64le, s390x or 32-bit Linux would see is an
`UnsatisfiedLinkError` from RocksDB's native loader. Two things narrow that:
XTable has no RocksDB code of its own — `grep -rl rocksdb --include=*.java`
over the repo returns nothing, it arrives transitively through Hudi and appears
only as a shade include at `xtable-utilities/pom.xml:725` — and this is the
convenience bundled jar, so anyone on those platforms can put `rocksdbjni` on
the classpath or build the bundle without the excludes.
My read is that the three are safe to assume away for a convenience
artifact, called out in the release notes. But 28.7 MB is a small enough share
of the win that I'll drop the excludes without argument if you'd rather not
make the assumption.
Verified: `unzip -v rocksdbjni-7.5.3.jar` → 6 dropped entries, 28,724,661
bytes compressed; 7 kept, 27,784,349 bytes.
*This comment was created with AI assistance.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
