vaibhavk1992 commented on PR #903:
URL: https://github.com/apache/incubator-xtable/pull/903#issuecomment-5386417087
Thanks for the review @slachiewicz
Spotless: fixed in 07cf223.
Why throw instead of falling back to Standalone:
DeltaConversionTarget.init()
unconditionally spins up its own SparkSession. A silent fallback would
mean a
Kernel-configured pipeline (chosen specifically to drop the Spark
dependency) pulls
Spark back in transparently the moment schema evolves — that undercuts the
point of
#886. Throwing is also more debuggable: the failure shows up immediately
as
SyncStatusCode.ERROR instead of surfacing later as "why did Standalone
write this
commit."
If you need schema evolution today: set
xtable.delta.target.use_kernel=false to route
that target through Standalone, which supports it. That's the escape hatch
this PR
preserves — the default flip stays out of scope until either
delta-io/delta#4305
lands or we deliberately accept the fallback tradeoff above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
