vaibhavk1992 commented on PR #903:
URL: https://github.com/apache/incubator-xtable/pull/903#issuecomment-5454781501
Tested #779 against Kernel specifically — added
ITDeltaLogTruncationSafetyCheck
(xtable-core/src/test/java/org/apache/xtable/) as a protocol-realistic
repro:
enough commits to force a real Delta checkpoint (per PROTOCOL.md's
"Metadata
cleanup," retention is required to always leave a checkpoint before
deleting older
commit files), then deleting only the pre-checkpoint JSON files.
With that setup, Kernel's isIncrementalSyncSafeFrom correctly returns
false — no
bug there. More importantly, I also tested the race where retention
cleanup runs
after the safety check already passed (check says true while files still
exist,
then they get deleted, then the actual read is attempted): Kernel throws
immediately with a clear, specific exception — timestamp is before the
earliest
available version 10 — rather than proceeding with stale or incomplete
data. So on
the Kernel path, #779 doesn't reproduce as a problem, under either the
straightforward or the race scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
