vinishjail97 commented on code in PR #923:
URL: https://github.com/apache/incubator-xtable/pull/923#discussion_r3984283181
##########
xtable-utilities/pom.xml:
##########
@@ -739,33 +765,19 @@
<include>org.xerial.snappy:snappy-java</include>
<include>org.yaml:snakeyaml</include>
<include>oro:oro</include>
-
<include>software.amazon.awssdk:annotations</include>
-
<include>software.amazon.awssdk:apache-client</include>
- <include>software.amazon.awssdk:auth</include>
- <include>software.amazon.awssdk:aws-core</include>
-
<include>software.amazon.awssdk:aws-json-protocol</include>
+ <!-- Only bundle; it already contains
internally-consistent
Review Comment:
Thanks for cleaning this up...can you use the jar built with this and
validate the existing demo docs don't break? If once that validation is done, I
can approve the PR. Adding it as part of the CI itself is another enhancement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
