abdul-traya commented on code in PR #923:
URL: https://github.com/apache/incubator-xtable/pull/923#discussion_r4003191750
##########
xtable-aws/src/main/java/org/apache/xtable/glue/table/DeltaGlueCatalogTableBuilder.java:
##########
@@ -48,6 +49,20 @@
/** Delta specific table operations for Glue catalog sync */
public class DeltaGlueCatalogTableBuilder implements
CatalogTableBuilder<TableInput, Table> {
+ // Standard Hive-compatible Parquet classes (Delta's on-disk file format).
Review Comment:
@vinishjail97 - no, these aren't related to the AWS SDK v2 changes, they got
mixed in from a separate fix on this branch.
The DeltaGlueCatalogTableBuilder change addresses a Unity Catalog Glue
Federation issue: a foreign catalog validates every table's StorageDescriptor
when listing a database, and throws InvalidObjectException for the entire
database on the first table missing InputFormat/OutputFormat/SerDe class.
Athena's own Delta reader tolerates these being null (it keys off
table_type/spark.sql.sources.provider instead), so it wasn't caught before.
Happy to split this into its own PR if you'd prefer keeping this one scoped
to the SDK v2 cleanup — let me know which you'd like.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
