abdul-traya commented on code in PR #923:
URL: https://github.com/apache/incubator-xtable/pull/923#discussion_r4003253427
##########
xtable-utilities/pom.xml:
##########
@@ -739,33 +765,19 @@
<include>org.xerial.snappy:snappy-java</include>
<include>org.yaml:snakeyaml</include>
<include>oro:oro</include>
-
<include>software.amazon.awssdk:annotations</include>
-
<include>software.amazon.awssdk:apache-client</include>
- <include>software.amazon.awssdk:auth</include>
- <include>software.amazon.awssdk:aws-core</include>
-
<include>software.amazon.awssdk:aws-json-protocol</include>
+ <!-- Only bundle; it already contains
internally-consistent
Review Comment:
Thanks — validated this. Built
xtable-utilities_2.12-0.5.0-SNAPSHOT-bundled.jar off this branch and ran
through RunSync/RunCatalogSync. The Glue path (glue-catalog.md /
how-to-catalog-sync.md) is the only doc that actually loads the trimmed AWS SDK
v2 classes — constructed and closed a GlueCatalogSyncClient (which exercises
the DefaultGlueClientFactory → credentials-provider shutdown path from the
original NoSuchMethodError), and it works cleanly with the new shaded jar.
Other catalog docs (HMS, Unity Catalog, BigLake, Fabric) don't touch these
modules, and the docker demo/ doesn't build xtable-utilities at all, so both
are unaffected.
Agreed CI coverage for this is a good follow-up but separate from this fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
