vinishjail97 commented on code in PR #938:
URL: https://github.com/apache/incubator-xtable/pull/938#discussion_r4064822853
##########
xtable-utilities/src/test/java/org/apache/xtable/utilities/TestRunSync.java:
##########
@@ -60,6 +64,79 @@ public void testGetDatasetConfigWithValidYAML() throws
IOException {
Assertions.assertNotNull(config);
}
+ @Test
+ public void testAllowUnsupportedDeletionVectorsSourceProperty() {
+ DatasetConfig.Table table =
+
DatasetConfig.Table.builder().allowUnsupportedDeletionVectors("true").build();
+
+ Properties sourceProperties = RunSync.getSourceProperties(table);
+
+ Assertions.assertEquals(
+ "true",
+ sourceProperties.getProperty(
+ DeltaConversionSourceConfig.ALLOW_UNSUPPORTED_DELETION_VECTORS));
+ }
+
+ @Test
+ public void testAllowUnsupportedDeletionVectorsAcceptsBooleanLiterals()
throws IOException {
+ String[][] configuredValues = {
Review Comment:
Nit: these value matrices are driven by `for` loops, so the first bad value
ends the test and the name does not say which value failed. Would
`@ParameterizedTest` with `@CsvSource` fit better, as
`TestDeltaConversionSourceConfig` already uses in this PR? Same for the four
equivalent tests in `TestRunCatalogSync`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
