vinishjail97 commented on code in PR #938:
URL: https://github.com/apache/incubator-xtable/pull/938#discussion_r4074238509
##########
xtable-utilities/src/test/java/org/apache/xtable/utilities/TestRunSync.java:
##########
@@ -60,6 +64,79 @@ public void testGetDatasetConfigWithValidYAML() throws
IOException {
Assertions.assertNotNull(config);
}
+ @Test
+ public void testAllowUnsupportedDeletionVectorsSourceProperty() {
+ DatasetConfig.Table table =
+
DatasetConfig.Table.builder().allowUnsupportedDeletionVectors("true").build();
+
+ Properties sourceProperties = RunSync.getSourceProperties(table);
+
+ Assertions.assertEquals(
+ "true",
+ sourceProperties.getProperty(
+ DeltaConversionSourceConfig.ALLOW_UNSUPPORTED_DELETION_VECTORS));
+ }
+
+ @Test
+ public void testAllowUnsupportedDeletionVectorsAcceptsBooleanLiterals()
throws IOException {
+ String[][] configuredValues = {
Review Comment:
Thanks for the quick turnaround @Akash3121. I went ahead and pushed the
parameterized version in 0af398d0 so this nit does not hold up the merge. It
also declares `junit-jupiter-params` in `xtable-utilities` test scope, since
the module did not have it yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
