[ 
https://issues.apache.org/jira/browse/HADOOP-14384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15998855#comment-15998855
 ] 

Anu Engineer commented on HADOOP-14384:
---------------------------------------

bq. Please do not refer to anyone's code as "badly executed", particularly that 
of a new contributor. 

My apologies, It was not intended to cause any hurt, I am sorry if it came 
across that way to you.  My reference to "good concept badly executed" was to 
make sure that I convey the understanding that I would like this to stay in 
code base, but we should make whatever fixes are needed to make it ship worthy. 
 This JIRA was confusing since only the sub-task so far is to make it private. 
So I was trying to understand where we are going with it.

bq.Since these changes affect compatibility we want to get the details right, 
but the patch and the idea are still largely good.
Marking this API as private did not seem to be a step towards that goal, hence 
my query. My query was precisely to understand what is the long term fix. The 
parent jira and this specific JIRA was/is very light on details.
 
[~eddyxu] I would think that doing option 2 might make what we are doing in 
this JIRA superfluous,   Would it not be easier to follow thru with that plan, 
if that is what is being contemplated ? 



> Reduce the visibility of {{FileSystem#newFSDataOutputStreamBuilder}} before 
> the API becomes stable
> --------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-14384
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14384
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs
>    Affects Versions: 2.9.0
>            Reporter: Lei (Eddy) Xu
>            Assignee: Lei (Eddy) Xu
>            Priority: Minor
>         Attachments: HADOOP-14384.00.patch, HADOOP-14384.01.patch
>
>
> Before {{HADOOP-14365}} finishes, we should limit the this API within Hadoop 
> project to prevent it being used by end users or other projects.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to