[
https://issues.apache.org/jira/browse/HADOOP-14384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000486#comment-16000486
]
Steve Loughran commented on HADOOP-14384:
-----------------------------------------
I'm trying not to cause trouble, and I don't think Anu was either; more he
misread my comments.
If the change is only in the HDFS client and used internally (private,
unstable, with a "really don't use this", then its probably OK to ship as *for
now*, I think it needs to go through some tuning and integration before being
unleashed on the FS API, And to be honest, given the history of
{{createNonRecursive()}}, people will start using if it meets a need, and then
it becomes a maintenance point.
A quick tag of @private will warn people to leave alone for now while we
iterate around deciding what is a good public/stable API, not just in how to
spec & test, but what variants of create() should be offered (me: drop the
recursive, others?), how to merge in with the FS spec and all our
implementation. Similarly, shouldn't {{append()}} be just a variant of the
call, returning a different builder or raising an exception? as far as posix is
concernted, there is only {{open()}}, here with the {{O_CREAT}} option.
And the work on adding an fadvise=random mode to S3A input has shown that i'd
be good to support custom features there (interesting issue: ignore vs. reject
unknown opts?).
If we look at what we could do with a builder model, it could improve how we
work with files. And while it will take time to be adopted outside our own
code, I would like to have one which can be adopted. What we have here is a
great start, not just existing but showing that it works internally. I just
want to carry that through to something which will be taken up in more places.
Anyway, sorry for pushing more work onto people, and I don't want to set up
some Posix-working-group style "committee for the defining of The Builder".
just trying to move it from an HDFS-internal to a broadly applicable API
> Reduce the visibility of {{FileSystem#newFSDataOutputStreamBuilder}} before
> the API becomes stable
> --------------------------------------------------------------------------------------------------
>
> Key: HADOOP-14384
> URL: https://issues.apache.org/jira/browse/HADOOP-14384
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 2.9.0
> Reporter: Lei (Eddy) Xu
> Assignee: Lei (Eddy) Xu
> Priority: Minor
> Attachments: HADOOP-14384.00.patch, HADOOP-14384.01.patch
>
>
> Before {{HADOOP-14365}} finishes, we should limit the this API within Hadoop
> project to prevent it being used by end users or other projects.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
