[ 
https://issues.apache.org/jira/browse/HADOOP-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16126355#comment-16126355
 ] 

stack commented on HADOOP-14284:
--------------------------------

bq. Does HBase shade across all code base, instead of just in client modules?

The whole code base.

We offer a shaded client jar for those contained to our public facing client 
API. We've done a bad job evangelizing it up to this but intend to go at it 
with gusto with our next major release on out. This project should work for 
those confined to our client API but as with hadoop, hbase has facets other 
than that of the client API. This is when the story gets messy; i.e. plugins or 
clients reading/writing hbase files apart from an hbase instance. Shading our 
internals helps as we avoid the possibility of clashes. On our backend, we also 
are too-tightly tied to our upstream, a project we are working to undo, but we 
are not there yet. The internal shading helps here too.

Using enforcer has been suggested over in our project. Will pass on our 
experience if anything noteworthy.

> Shade Guava everywhere
> ----------------------
>
>                 Key: HADOOP-14284
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14284
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.0.0-alpha4
>            Reporter: Andrew Wang
>            Assignee: Tsuyoshi Ozawa
>            Priority: Blocker
>         Attachments: HADOOP-14238.pre001.patch, HADOOP-14284.002.patch, 
> HADOOP-14284.004.patch, HADOOP-14284.007.patch, HADOOP-14284.010.patch, 
> HADOOP-14284.012.patch
>
>
> HADOOP-10101 upgraded the guava version for 3.x to 21.
> Guava is broadly used by Java projects that consume our artifacts. 
> Unfortunately, these projects also consume our private artifacts like 
> {{hadoop-hdfs}}. They also are unlikely on the new shaded client introduced 
> by HADOOP-11804, currently only available in 3.0.0-alpha2.
> We should shade Guava everywhere to proactively avoid breaking downstreams. 
> This isn't a requirement for all dependency upgrades, but it's necessary for 
> known-bad dependencies like Guava.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to