[ https://issues.apache.org/jira/browse/HADOOP-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16139419#comment-16139419 ]
Vinod Kumar Vavilapalli commented on HADOOP-14284: -------------------------------------------------- Paging [~djp] for his opinion. This is a long JIRA and there's been a lot of back-and-forth, so just reiterating. I am not a fan of this but if you want to shade everything because of the hadoop-hdfs module issue, you should definitely leave YARN and mapreduce out of this - see my comment above, *snip* bq. I think there is one thing we should definitely do. YARN and mapreduce have always had separate client libraries. And the expectation of users has always been to not depend on the server jars. So you should definitely skip YARN server side modules and mapreduce non-client modules from shading. > Shade Guava everywhere > ---------------------- > > Key: HADOOP-14284 > URL: https://issues.apache.org/jira/browse/HADOOP-14284 > Project: Hadoop Common > Issue Type: Bug > Components: build > Affects Versions: 3.0.0-alpha4 > Reporter: Andrew Wang > Assignee: Tsuyoshi Ozawa > Priority: Blocker > Attachments: HADOOP-14238.pre001.patch, HADOOP-14284.002.patch, > HADOOP-14284.004.patch, HADOOP-14284.007.patch, HADOOP-14284.010.patch, > HADOOP-14284.012.patch > > > HADOOP-10101 upgraded the guava version for 3.x to 21. > Guava is broadly used by Java projects that consume our artifacts. > Unfortunately, these projects also consume our private artifacts like > {{hadoop-hdfs}}. They also are unlikely on the new shaded client introduced > by HADOOP-11804, currently only available in 3.0.0-alpha2. > We should shade Guava everywhere to proactively avoid breaking downstreams. > This isn't a requirement for all dependency upgrades, but it's necessary for > known-bad dependencies like Guava. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org