[ 
https://issues.apache.org/jira/browse/HADOOP-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131342#comment-16131342
 ] 

Daniel Templeton commented on HADOOP-14284:
-------------------------------------------

bq. We are still in discussion for a decent solution. From my understanding, 
this shouldn't be a real blocker for beta.

[~djp], classpath isolation has been one of the top level features for Hadoop 
3.0 for as long as I can remember.  If we do actually want to ship it in Hadoop 
3.0, then we want to get the work in for beta1 if possible.  Please help us by 
sharing what you see as open issues with the current proposal(s).

Sounds like we have two options on the table:

# Shade just the client artifacts
# Shade everything

(With all caveats and explanations as have already been covered above.)  The 
idea of shading just the clients limits the impact, but it leaves open the door 
for unexpected downstream compatibility issues.  It also gives us an 
inconsistent source base if we go the route of changing the imports to the 
relocated packages.  Shading everything sounds safer, but is a larger change 
and may have a larger impact on the build process.  It sounds to me like the 
3rd party JAR should make the build process impact small.  For these reasons, 
I'd would say to continue on the original path.  Either way, though, let's make 
a call.

> Shade Guava everywhere
> ----------------------
>
>                 Key: HADOOP-14284
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14284
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.0.0-alpha4
>            Reporter: Andrew Wang
>            Assignee: Tsuyoshi Ozawa
>            Priority: Blocker
>         Attachments: HADOOP-14238.pre001.patch, HADOOP-14284.002.patch, 
> HADOOP-14284.004.patch, HADOOP-14284.007.patch, HADOOP-14284.010.patch, 
> HADOOP-14284.012.patch
>
>
> HADOOP-10101 upgraded the guava version for 3.x to 21.
> Guava is broadly used by Java projects that consume our artifacts. 
> Unfortunately, these projects also consume our private artifacts like 
> {{hadoop-hdfs}}. They also are unlikely on the new shaded client introduced 
> by HADOOP-11804, currently only available in 3.0.0-alpha2.
> We should shade Guava everywhere to proactively avoid breaking downstreams. 
> This isn't a requirement for all dependency upgrades, but it's necessary for 
> known-bad dependencies like Guava.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to