[ 
https://issues.apache.org/jira/browse/HADOOP-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16139447#comment-16139447
 ] 

Sean Busbey commented on HADOOP-14284:
--------------------------------------

I maintain the same view I had before:

{quote}
bq. Unfortunately for HDFS, there are a bunch of downstreams incorrectly 
including our server artifacts, so for HDFS, I think we need to shade those too.
This seems like the wrong approach IMHO. There's no incentive for folks to ever 
start respecting the public/not public interface we put up. If we're only 
concerned about client side impact, then we should just upgrade guava and close 
this jira. That way if folks run into a problem with the guava uprade, we just 
tell them to use the correct client jars instead of server jars. we can even 
put it in the release note for the guava upgrade.
{quote}

Essentially, if we're not shading the server-side for YARN / MapReduce then we 
ought not. For client-side stuff we should just tell people who want to not 
have a Guava conflict that they need to use the published shaded client jars.

> Shade Guava everywhere
> ----------------------
>
>                 Key: HADOOP-14284
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14284
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.0.0-alpha4
>            Reporter: Andrew Wang
>            Assignee: Tsuyoshi Ozawa
>            Priority: Blocker
>         Attachments: HADOOP-14238.pre001.patch, HADOOP-14284.002.patch, 
> HADOOP-14284.004.patch, HADOOP-14284.007.patch, HADOOP-14284.010.patch, 
> HADOOP-14284.012.patch
>
>
> HADOOP-10101 upgraded the guava version for 3.x to 21.
> Guava is broadly used by Java projects that consume our artifacts. 
> Unfortunately, these projects also consume our private artifacts like 
> {{hadoop-hdfs}}. They also are unlikely on the new shaded client introduced 
> by HADOOP-11804, currently only available in 3.0.0-alpha2.
> We should shade Guava everywhere to proactively avoid breaking downstreams. 
> This isn't a requirement for all dependency upgrades, but it's necessary for 
> known-bad dependencies like Guava.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to